Skip to content

Remove common directory from mod_dirs#1246

Closed
sbryngelson wants to merge 1 commit into
MFlowCode:masterfrom
sbryngelson:test-claude-3
Closed

Remove common directory from mod_dirs#1246
sbryngelson wants to merge 1 commit into
MFlowCode:masterfrom
sbryngelson:test-claude-3

Conversation

@sbryngelson

@sbryngelson sbryngelson commented Feb 22, 2026

Copy link
Copy Markdown
Member

User description

Description

Summarize your changes and the motivation behind them.

Fixes #(issue)

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other: describe

Testing

How did you test your changes?

Checklist

  • I added or updated tests for new behavior
  • I updated documentation if user-facing behavior changed

See the developer guide for full coding standards.

GPU changes (expand if you modified src/simulation/)
  • GPU results match CPU results
  • Tested on NVIDIA GPU or AMD GPU

CodeAnt-AI Description

Stop including build/common in module search paths

What Changed

  • The language-server configuration no longer includes "build/common/" when searching for compiled module files.
  • Module definitions located in "build/common/" will no longer be considered for symbol lookup, hover information, diagnostics, or code actions.
  • This reduces duplicate or misleading module matches coming from the build/common folder during editor features.

Impact

✅ Fewer duplicate module matches in editor features
✅ Clearer module resolution for workspace files
✅ Reduced noise in diagnostics caused by build/common modules

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

  • Chores
    • Simplified module search configuration by removing an unused directory path.

Copilot AI review requested due to automatic review settings February 22, 2026 21:59
@codeant-ai

codeant-ai Bot commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@coderabbitai

coderabbitai Bot commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

A single line was removed from the .fortlsrc configuration file, eliminating the "build/common/" directory from the module search paths list. No functional changes or alterations to other configuration settings.

Changes

Cohort / File(s) Summary
Configuration Update
.fortlsrc
Removed "build/common/" entry from the mod_dirs list, reducing the external module search paths.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 One path removed with a gentle hop,
The build/common/ had to stop,
Cleaner config, lighter load,
A simpler way down the mod-dir road! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description uses the template structure but fails to fill in key sections with actual details about the changes, motivation, testing, or type of change. Provide specific details: fill in the Description section with motivation for removing build/common/, select the Type of change, and describe how the change was tested.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing the common directory from mod_dirs configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codeant-ai

codeant-ai Bot commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

CodeAnt AI finished reviewing your PR.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the fortls (Fortran language server) configuration by adjusting the list of module output directories to no longer include a build/common/ entry.

Changes:

  • Removed build/common/ from .fortlsrc mod_dirs.

Comment thread .fortlsrc
@@ -41,7 +41,6 @@
"build/pre_process/",
"build/simulation/",
"build/post_process/",

Copilot AI Feb 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mod_dirs now ends with a trailing comma after the last entry ("build/post_process/",). .fortlsrc is parsed as JSON by fortls, and trailing commas make it invalid, which can prevent the language server from loading this config. Remove the trailing comma or add another valid entry.

Suggested change
"build/post_process/",
"build/post_process/"

Copilot uses AI. Check for mistakes.
@sbryngelson sbryngelson deleted the test-claude-3 branch February 22, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants